Skip to content

Conversation

@huxuan
Copy link
Member

@huxuan huxuan commented Mar 27, 2024

I suggest to config semantic release and other node based tools in the universal package.json if they supported.

@huxuan huxuan requested a review from msclock March 27, 2024 09:08
@huxuan huxuan changed the title chore: config commitlint in the package.json chore: move commitlint config to package.json Mar 27, 2024
Copy link
Contributor

@msclock msclock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested with package.json, why I use .releaserc.js is some js can be written in that file makes me implement some simple file operations. But it is true using the universal configuration file is best practice if we don't need to do some complicated operations.

@huxuan huxuan force-pushed the xuan.hu/refactor-commitlint-config branch from a7e3a21 to 4da4c28 Compare March 27, 2024 11:01
@huxuan
Copy link
Member Author

huxuan commented Mar 27, 2024

I haven't tested with package.json, why I use .releaserc.js is some js can be written in that file makes me implement some simple file operations. But it is true using the universal configuration file is best practice if we don't need to some complicated operations.

OK, when we have specified needs for js script, we can change it bach then. :-)

@huxuan huxuan enabled auto-merge (squash) March 27, 2024 11:01
@huxuan huxuan force-pushed the xuan.hu/refactor-commitlint-config branch from 4da4c28 to 15443e4 Compare March 27, 2024 14:08
@huxuan huxuan merged commit 5c2b93e into serious-scaffold:main Mar 27, 2024
@huxuan huxuan deleted the xuan.hu/refactor-commitlint-config branch March 27, 2024 14:09
@serious-scaffold
Copy link
Contributor

🎉 This PR is included in version 0.0.51 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants