Skip to content

Conversation

@huxuan
Copy link
Member

@huxuan huxuan commented Apr 26, 2025


📚 Documentation preview 📚: https://ss-python--979.org.readthedocs.build/en/979/

@huxuan huxuan requested a review from Copilot April 26, 2025 10:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the formatting of several GitHub workflow YAML files to improve consistency and readability. Key changes include adding explicit permissions, updating trigger configurations (on: blocks), and standardizing the formatting of string literals (e.g., python-version) across workflows.

Reviewed Changes

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
template/{% if repo_platform == 'github' %}.github{% endif %}/workflows/commitlint.yml Added explicit trigger and permissions blocks while removing a duplicate on: block.
.github/workflows/renovate.yml Introduced schedule and workflow_dispatch triggers with corresponding permissions; removed redundant on: block.
.github/workflows/release.yml Standardized quotes for python-version and formatted the python-version matrix consistently.
.github/workflows/readthedocs-preview.yml Reordered and reformatted the workflow by moving concurrency and jobs blocks to align with the new format.
.github/workflows/ci.yml Added permissions section and updated string quotes in the python-version matrix.
Files not reviewed (5)
  • .github/workflows/commitlint.yml: Language not supported
  • template/{% if repo_platform == 'github' %}.github{% endif %}/workflows/ci.yml.jinja: Language not supported
  • template/{% if repo_platform == 'github' %}.github{% endif %}/workflows/readthedocs-preview.yml.jinja: Language not supported
  • template/{% if repo_platform == 'github' %}.github{% endif %}/workflows/release.yml.jinja: Language not supported
  • template/{% if repo_platform == 'github' %}.github{% endif %}/workflows/renovate.yml.jinja: Language not supported

@huxuan huxuan merged commit ef0ee06 into serious-scaffold:main Apr 26, 2025
19 checks passed
@huxuan huxuan deleted the xuan.hu/format-github-actions branch April 26, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant