Skip to content

fix: git not installed errors during init#79

Merged
EvolutionX-10 merged 5 commits into
sern-handler:mainfrom
SrIzan10:no-more-git-errors
Sep 22, 2022
Merged

fix: git not installed errors during init#79
EvolutionX-10 merged 5 commits into
sern-handler:mainfrom
SrIzan10:no-more-git-errors

Conversation

@SrIzan10
Copy link
Copy Markdown
Member

There were some problems with git not being installed when initiating sern, AND THIS SHOULD WORK!

Everything is tested, so there are no problems whatsoever on this PR.

ENJOY!

@SrIzan10
Copy link
Copy Markdown
Member Author

SrIzan10 commented Sep 17, 2022

Code_7YGsqEqSmt.mp4

demonstration that it works (without you guys testing it!)

@SrIzan10
Copy link
Copy Markdown
Member Author

A fallback way to download the repo is by downloading a zip file.

WIP probably idk

@SrIzan10
Copy link
Copy Markdown
Member Author

for example, this link downloads the CLI github repo:
https://github.com/sern-handler/cli/archive/refs/heads/main.zip

@SrIzan10
Copy link
Copy Markdown
Member Author

Hey!

I can't make a PR of the fallback way of downloading templates without this PR being merged.

If you want to see how I did the template download magic, you can see it on this commit.

Thanks!

@jacoobes
Copy link
Copy Markdown
Member

this shouldnt give breaking changes

@SrIzan10
Copy link
Copy Markdown
Member Author

SrIzan10 commented Sep 22, 2022 via email

@jacoobes
Copy link
Copy Markdown
Member

wasn’t the ! relevant changes?

On Thu, 22 Sep 2022 at 7:50 AM, Jacob Nguyen @.> wrote: this shouldnt give breaking changes — Reply to this email directly, view it on GitHub <#79 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP646AR6EJ4LNVJSRU6IPXTV7PXRVANCNFSM6AAAAAAQPALUFQ . You are receiving this because you authored the thread.Message ID: @.>

I believe the ! means breaking changes in this commit / pull request, but i think its okay, evo can change it

@SrIzan10
Copy link
Copy Markdown
Member Author

the title of the pr is !, the commits aren't !
image

@SrIzan10 SrIzan10 changed the title fix!: Git not installed errors when initing sern without git installed. fix: Git not installed errors when initing sern without git installed. Sep 22, 2022
@SrIzan10
Copy link
Copy Markdown
Member Author

image
ayo 💀

Copy link
Copy Markdown
Member

@jacoobes jacoobes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot what this fixed, but i think ethan explained it to me before

@EvolutionX-10
Copy link
Copy Markdown
Member

Lol i knew it, was gonna edit the pr title just before merging

@EvolutionX-10 EvolutionX-10 changed the title fix: Git not installed errors when initing sern without git installed. fix: git not installed errors during init Sep 22, 2022
@EvolutionX-10 EvolutionX-10 merged commit 69287ab into sern-handler:main Sep 22, 2022
@SrIzan10
Copy link
Copy Markdown
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants