deps: require serverkit v1.0.0+ / Support Ruby v2.7+ #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to handle falsy attribute correctly
- ci: CI against Ruby 2.7, 3.0
toshimaru
force-pushed
the
require-serverkit-v1
branch
from
078c649 to
caf0997
Compare
toshimaru
changed the title
toshimaru
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dependency requirements and Ruby version support while adding clearer usage instructions.
- Lower Ruby version requirement in the gemspec to ">= 2.7.0".
- Require serverkit dependency with ">= 1.0.0".
- Update the test workflow to include Ruby 2.7 and Ruby 3.0, and provide usage instructions in the README.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| serverkit-mise.gemspec | Modified Ruby version requirement and added a minimum version for serverkit. |
| README.md | Added prerequisites and a basic usage example for the plugin. |
| .github/workflows/test.yml | Updated Ruby versions in the matrix to reflect support for Ruby v2.7+ and v3.0+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to handle falsy attribute correctly