Skip to content

Conversation

@robertobasile84
Copy link

Without this change, hitting the root drive (whatever letter) would case a RangeError: Maximum call stack size exceeded

Without this change, hitting the root drive (whatever letter) would case a RangeError: Maximum call stack size exceeded
@thdxr thdxr self-requested a review August 30, 2021 15:19
@thdxr thdxr added the bug Something isn't working label Aug 30, 2021
@thdxr
Copy link
Contributor

thdxr commented Aug 30, 2021

@robertobasile84 Thanks for finding this! Left some minor style comments but can get this merged in once those are updated

@jfriend00
Copy link

jfriend00 commented Aug 30, 2021

The last solution shown in this stackoverflow post https://stackoverflow.com/a/68977855/816620 is a bit more elegant and would also handle Windows UNC paths (paths that start with \\) that are sometimes used instead of drive letters or paths that don't contain a drive letter, but start with \. That might be better than the regex which only handles drive letters.

@thdxr thdxr merged commit 3471750 into sst:master Aug 31, 2021
@fwang
Copy link
Contributor

fwang commented Sep 2, 2021

This is released in v0.40.6. To update, run:

npm install --save --save-exact @serverless-stack/cli@0.40.6 @serverless-stack/resources@0.40.6

Sorry for the delay @robertobasile84! Thanks again for the help @jfriend00!

@robertobasile84 robertobasile84 deleted the patch-1 branch September 2, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants