fix: RemixSite polyfilling with treeshaking enabled #2117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woops, test broke as was unable to reference the |
fwang
reviewed
Oct 4, 2022
There was a problem hiding this comment.
Thanks @ctrlplusb! I just had 2 minor things that I wanted to clarify.
| // doesn't appear to guarantee this, we therefore leverage ESBUild's | ||
| // `inject` option to ensure that the polyfills are injected at the top of | ||
| // the bundle. | ||
| inject: [polyfillDest], |
There was a problem hiding this comment.
Does passing in polyfillSource not work?
There was a problem hiding this comment.
Unfortunately not. That was my original implementation, but then ESBuild tried to do package resolution to the referenced remix package which failed the unit tests. If we added the remix package as a dependency to the resources package (or root) then it could work. As a dev dependency maybe, but I felt it better to go this route.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables treeshaking of ESBuild whilst also ensuring that the required Remix polyfills do not get removed during the treeshake. Results in smaller bundle sizes that still work when deployed.
Remix by default opts into treeshaking via the
"sideEffects": falseconfig inpackage.json. Users can opt out per their needs still.Tested and verified against a deployed application.