feature: change to zipdeploy & run from package

src/config.ts

@@ -13,7 +13,7 @@ export const constants = {
   scmCommandApiPath: '/api/command',
   scmDomain: '.scm.azurewebsites.net',
   scmVfsPath: '/api/vfs/site/wwwroot/',
-  scmZipApiPath: '/api/zip/site/wwwroot/'
+  scmZipDeployApiPath: '/api/zipdeploy'
 };
 
 export default constants;

src/plugins/deploy/azureDeployPlugin.ts

@@ -7,28 +7,17 @@ export class AzureDeployPlugin {
 
   constructor(private serverless: Serverless, private options: Serverless.Options) {
     this.hooks = {
-      'before:deploy:deploy': this.beforeDeploy.bind(this),
       'deploy:deploy': this.deploy.bind(this)
     };
   }
 
-  private async beforeDeploy() {
-    const functionAppService = new FunctionAppService(this.serverless, this.options);
-    const functionApp = await functionAppService.get();
-
-    if (functionApp) {
-      await functionAppService.cleanUp(functionApp);
-    }
-  }
-
   private async deploy() {
     const resourceService = new ResourceService(this.serverless, this.options);
     await resourceService.deployResourceGroup();
 
     const functionAppService = new FunctionAppService(this.serverless, this.options);
-    const functionApp = await functionAppService.deploy();
 
+    const functionApp = await functionAppService.deploy();
     await functionAppService.uploadFunctions(functionApp);
-    await functionAppService.syncTriggers(functionApp);
   }
 }

src/provider/armTemplates/azuredeploy.json

@@ -103,6 +103,10 @@
                         {
                             "name": "WEBSITE_NODE_DEFAULT_VERSION",
                             "value": "8.11.1"
+                        },
+                        {
+                            "name": "WEBSITE_RUN_FROM_PACKAGE",
+                            "value": "1"
                         }
                     ]
                 }

src/services/functionAppService.ts

@@ -7,6 +7,7 @@ import jsonpath from 'jsonpath';
 import _ from 'lodash';
 import Serverless from 'serverless';
 import { BaseService } from './baseService';
+import { constants } from '../config';
 
 export class FunctionAppService extends BaseService {
   private resourceClient: ResourceManagementClient;
@@ -79,27 +80,49 @@ export class FunctionAppService extends BaseService {
     return response.data.value || [];
   }
 
-  public async uploadFunctions(functionApp): Promise<any> {
-    this.serverless.cli.log('Creating azure functions');
+  public async uploadFunctions(functionApp) {
+    await this.zipDeploy(functionApp);
+  }
 
-    const scmDomain = functionApp.enabledHostNames[0];
+  private async zipDeploy(functionApp) {
+    const functionAppName = functionApp.name;
+    this.serverless.cli.log(`Deploying zip file to function app: ${functionAppName}`);
+
+    // Upload function artifact if it exists, otherwise the full service is handled in 'uploadFunctions' method
     const functionZipFile = this.serverless.service['artifact'];
+    if (!functionZipFile) {
+      throw new Error('No zip file found for function app');
+    }
 
-    this.serverless.cli.log(`-> Deploying service package @ ${functionZipFile}`);
+    this.serverless.cli.log(`-> Uploading ${functionZipFile}`);
 
+    const uploadUrl = `https://${functionAppName}${constants.scmDomain}${constants.scmZipDeployApiPath}`;
+    this.serverless.cli.log(`-> Upload url: ${uploadUrl}`);
+
+    // https://github.com/projectkudu/kudu/wiki/Deploying-from-a-zip-file-or-url
     const requestOptions = {
       method: 'POST',
-      uri: `https://${scmDomain}/api/zipdeploy/`,
+      uri: uploadUrl,
       json: true,
       headers: {
         Authorization: `Bearer ${this.credentials.tokenCache._entries[0].accessToken}`,
-        Accept: '*/*'
+        Accept: '*/*',
+        ContentType: 'application/octet-stream',
       }
     };
 
-    await this.sendFile(requestOptions, functionZipFile);
+    try {
+      await this.sendFile(requestOptions, functionZipFile);
+      this.serverless.cli.log('-> Function package uploaded successfully');
+    } catch (e) {
+      throw new Error(`Error uploading zip file:\n  --> ${e}`);
+    }
   }
 
+  /**
+   * create all necessary resources as defined in src/provider/armTemplates
+   *    resource-group, storage account, app service plan, and app service at the minimum
+   */
   public async deploy() {
     this.serverless.cli.log(`Creating function app: ${this.serviceName}`);
     let parameters: any = { functionAppName: { value: this.serviceName } };