This repository was archived by the owner on Dec 9, 2024. It is now read-only.
feat: Mock of Serverless object for unit tests #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
approved these changes
May 23, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Added some feedback - let's discuss if not clear before merging.
src/test/mockFactory.ts
Outdated
| import PluginManager = require('serverless/classes/PluginManager'); | ||
|
|
||
| export class MockFactory { | ||
| public static createTestServerless(service?: Service, utils?: Utils, pluginManager?: PluginManager): Serverless { |
Contributor
There was a problem hiding this comment.
Do you see a use case where we would want to manually create utils or pluginManager? I would expect if we wanted to mock any of those calls we would just spy/mock on them after instantiation.
src/test/mockFactory.ts
Outdated
| } | ||
| } | ||
|
|
||
| public static createTestPluginManager(): PluginManager { |
Contributor
There was a problem hiding this comment.
I would change these to private if we don't expect to use them directly.
src/test/mockFactory.ts
Outdated
|
|
||
| export class MockFactory { | ||
| public static createTestServerless(service?: Service, utils?: Utils, pluginManager?: PluginManager): Serverless { | ||
| const sls = new Serverless(); |
Contributor
There was a problem hiding this comment.
We should expose the serverless config param in this mock factory that gets passed into Serverless ctor.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.