This repository was archived by the owner on Dec 9, 2024. It is now read-only.
test: Unit tests for deploy, login, package, delete and APIM plugins #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarlow12
changed the title
mydiemho
suggested changes
May 24, 2019
Contributor
mydiemho
left a comment
mydiemho
left a comment
There was a problem hiding this comment.
marvelous job! have some questions about some changes, let me know if any doesn't make sense
| catch (e) { | ||
| this.serverless.cli.log('Error logging into azure'); | ||
| this.serverless.cli.log(e); | ||
| this.serverless.cli.log(`${e}`); |
Contributor
There was a problem hiding this comment.
we should throw error and short circuit when login failed.
| BindingUtils.getBindingsMetaData(sls); | ||
| expect(sls.cli.log).toBeCalledWith('Parsing Azure Functions Bindings.json...'); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
are we testing other methods in a different PR?
| @@ -0,0 +1,24 @@ | |||
| export const constants = { | |||
Contributor
There was a problem hiding this comment.
config.js also export constants, is this gonna clash?
|
|
||
| describe('Login Plugin', () => { | ||
|
|
||
| const authResponse = MockFactory.createTestAuthResponse(); |
Contributor
There was a problem hiding this comment.
lots of duplicate code for setting up AzureLoginService. can we move some of them to a beforeEach?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureLoginServiceinvokeHook)