This repository was archived by the owner on Dec 9, 2024. It is now read-only.
test: Unit tests for Azure Index #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
approved these changes
May 31, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
1 comment to review - otherwise looks good.
| import { AzureApimFunctionPlugin } from "./plugins/apim/apimFunctionPlugin"; | ||
|
|
||
| export class AzureIndex { | ||
| export default class AzureIndex { |
Contributor
There was a problem hiding this comment.
Does adding this default screw up any of the exports that serverless cares about? We initially saw some weirdness trying to use standard ES6 module export features with the root sls plugin.
Contributor
Author
There was a problem hiding this comment.
It seems like as long as we have the module.exports at the end, it still works. Ran some deploys with this, and it seemed to work ok
PIC123
approved these changes
Jun 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [AB#18742]