ci: Added NPM deployment info to .travis.yml #158
Conversation
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
LGTM - Added a couple questions and comments.
|
|
||
| after_success: | ||
| - cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage | ||
| - cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage |
There was a problem hiding this comment.
Does this push the coverage report up to coveralls automatically?
There was a problem hiding this comment.
Yes, it seems automagic, but our coverage badge is still unknown, and I'm guessing that's because we haven't had it run on master yet.
There was a problem hiding this comment.
@mydiemho might know, but my guess is that it targets a default branch (master). I wonder if that's something we can change? Everything will get there eventually...
.travis.yml
Outdated
| - npm install | ||
| script: | ||
| - npm test | ||
| - npm test |
There was a problem hiding this comment.
should we also add linting verification? Or is that a pre call on test
There was a problem hiding this comment.
Exactly. Now that you mention it though, we should be calling npm run build so that we run tsc as well. Currently, test runs as a precursor to build. I think I saw that change in your incoming PR, so maybe we can update whichever one comes in last
tbarlow12
force-pushed
the
tabarlow/npm-release
branch
from
337ce8b to
769eb3f
Compare
Fixed compile issue serverless#160 on windows by adding shx npm package to use in build scripts. Also added some local dev instructions to Readme.md Made numbering in local dev instructions in readme.md sequential. Signed Commit Made numbering in local dev sintructions in readme.md sequential.
No description provided.