This repository was archived by the owner on Dec 9, 2024. It is now read-only.
feat: Azure region & stage defaults #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
commented
Jun 19, 2019
tbarlow12
approved these changes
Jun 20, 2019
Contributor
tbarlow12
left a comment
tbarlow12
left a comment
There was a problem hiding this comment.
Looks great. Had a couple questions, but nothing big
mydiemho
suggested changes
Jun 20, 2019
src/services/baseService.ts
Outdated
| } | ||
|
|
||
| protected getStage(): string { | ||
| return this.options.stage || this.serverless.service.provider.stage || "dev"; |
Contributor
There was a problem hiding this comment.
can remove the last section since we're already setting default value for stage in setDefaultValues
pjlittle
reviewed
Jun 20, 2019
pjlittle
reviewed
Jun 20, 2019
pjlittle
approved these changes
Jun 20, 2019
mydiemho
approved these changes
Jun 20, 2019
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
Ensures valid Azure values are set for region and stage. Renames instances of "location" to "region" to align with core naming convention.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures valid Azure values are set for region and stage. Renames instances of "location" to "region" to align with core naming convention.