Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Conversation

@mydiemho
Copy link
Contributor

so user don't have to login every time they run sls deploy

so user don't have to login everytime they run
`sls deploy`
@mydiemho mydiemho changed the title [Testing] add script to generate service principal to ease testing [util] add script to generate service principal to ease testing Jun 20, 2019
@mydiemho mydiemho changed the title [util] add script to generate service principal to ease testing util: add script to generate service principal to ease testing Jun 20, 2019

SP_NAME=${1:-"http://FunctionsTestingPrincipal"}

SUBSCRIPTION=$(az account show | jq .name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super handy script 🙂

We should add some notes -- not everyone has jq available in their path (or knows what it is) -- we should just call that out. Likewise for ${1:-"http://FunctionsTestingPrincipal"} so that folks know you can pass in a value for the service principal name, if not will default to that Uri value.

Some comments at the top should suffice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tbarlow12 tbarlow12 self-requested a review June 21, 2019 16:51
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wbreza wbreza self-requested a review June 21, 2019 23:20
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mydiemho mydiemho merged commit bc6ca5a into dev Jun 22, 2019
@mydiemho mydiemho deleted the myho/addSPScript branch June 22, 2019 00:31
tbarlow12 pushed a commit that referenced this pull request Sep 13, 2019
so user don't have to login everytime they run
`sls deploy`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants