feat: Azure Blob Storage service #177
Conversation
|
@tbarlow12 please also add to description on what this PR is about |
PIC123
left a comment
PIC123
left a comment
There was a problem hiding this comment.
One small comment, but otherwise looks good!
| * @param blobName Blob to delete | ||
| */ | ||
| public async deleteFile(containerName: string, blobName: string): Promise<void> { | ||
| const blockBlobUrl = await this.getBlockBlobURL(containerName, blobName) |
There was a problem hiding this comment.
Can we make this one line like you have done with the deleteContainer method?
There was a problem hiding this comment.
That's a good question... Do they both get awaited?
mydiemho
left a comment
mydiemho
left a comment
There was a problem hiding this comment.
I might be confused about how the blob sdk work, but there are undefined argument used
| const containerURL = this.getContainerURL(containerName); | ||
| do { | ||
| const listBlobsResponse = await containerURL.listBlobFlatSegment( | ||
| Aborter.none, |
There was a problem hiding this comment.
I see this in a few places here. What does it do?
There was a problem hiding this comment.
i believe marker is used for paging scenarios. It's undefined on the first iteration so the first page of data is returned.
| do { | ||
| const listContainersResponse = await this.getServiceURL().listContainersSegment( | ||
| Aborter.none, | ||
| marker, |
There was a problem hiding this comment.
same, marker is not defined first loop
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Added a few comments - otherwise looks good.
| const containerURL = this.getContainerURL(containerName); | ||
| do { | ||
| const listBlobsResponse = await containerURL.listBlobFlatSegment( | ||
| Aborter.none, |
There was a problem hiding this comment.
i believe marker is used for paging scenarios. It's undefined on the first iteration so the first page of data is returned.
| do { | ||
| const listContainersResponse = await this.getServiceURL().listContainersSegment( | ||
| Aborter.none, | ||
| marker, |
| * @param ext - Extension of files to filter on when retrieving files | ||
| * from container | ||
| */ | ||
| public async listFiles(containerName: string, ext?: string): Promise<string[]> { |
There was a problem hiding this comment.
Please validate input arguments using Guard to make sure they satisfy the method requirements.
| * Get ServiceURL object for Azure Blob Storage Account | ||
| */ | ||
| private getServiceURL(): ServiceURL { | ||
| const credential = this.credentials |
There was a problem hiding this comment.
Any reason not to use this.credentials directly vs split out into separate variable?
Wrapper service for Azure Blob Storage functionality. To be used in update of deployment process for rollback capability. Resolves [AB#361]
Wrapper service for Azure Blob Storage functionality. To be used in update of deployment process for rollback capability.
Resolves [AB#361]