This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: Ensures the correct SCM domain is found for uploading zip package #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydiemho
approved these changes
Jun 25, 2019
Contributor
mydiemho
left a comment
mydiemho
left a comment
There was a problem hiding this comment.
looks good, just have one comment about the custom path.
| ], | ||
| } | ||
|
|
||
| const expectedUploadUrl = `https://${customApp.enabledHostNames[1]}/api/zipdeploy/`; |
Contributor
There was a problem hiding this comment.
does Azure provide some API where we can check for this? What if they change the scm domain url?
Contributor
Author
There was a problem hiding this comment.
@mydiemho Not that i am aware of today. Looks like these are the 2 well known varients.
https://blogs.msdn.microsoft.com/benjaminperkins/2017/11/08/how-to-access-kudu-scm-for-an-azure-app-service-environment-ase/
Contributor
There was a problem hiding this comment.
can we include this as a comment so future developers know where this came from?
pjlittle
approved these changes
Jun 25, 2019
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
#178) The SCM domain is different based on the type of function app deployment. In a typical function app, the SCM domain is always {appName}.scm.azurewebsites.net. When deploying a function into an App Service Environment (ASE) the SCM domain is a sub domain off of the ASE, ex) {appName}.scm.{asePath}.p.azurewebsites.net This fix addresses the difference in finding the correct SCM domain to deploy the zip package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SCM domain is different based on the type of function app deployment. In a typical function app, the SCM domain is always {appName}.scm.azurewebsites.net.
When deploying a function into an App Service Environment (ASE) the SCM domain is a sub domain off of the ASE, ex) {appName}.scm.{asePath}.p.azurewebsites.net
This fix addresses the difference in finding the correct SCM domain to deploy the zip package.