This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Feat: Invoke Plugin #188
Merged
Feat: Invoke Plugin #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neerajmandal
force-pushed
the
t-nemand/invoke-function
branch
from
c6a5d50 to
3a6894a
Compare
wbreza
suggested changes
Jul 3, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
This is a great start! Left some feedback. Let me know if you have any questions.
wbreza
reviewed
Jul 3, 2019
wbreza
reviewed
Jul 3, 2019
wbreza
reviewed
Jul 3, 2019
wbreza
reviewed
Jul 3, 2019
wbreza
reviewed
Jul 3, 2019
wbreza
reviewed
Jul 3, 2019
wbreza
reviewed
Jul 3, 2019
tbarlow12
reviewed
Jul 3, 2019
Contributor
tbarlow12
left a comment
tbarlow12
left a comment
There was a problem hiding this comment.
Wallace left some great feedback :) Added a couple comments, but agreed - great start!
tbarlow12
approved these changes
Jul 8, 2019
Contributor
tbarlow12
left a comment
tbarlow12
left a comment
There was a problem hiding this comment.
Almost there :) Just one file to remove and some whitespace changes, and you should be good to go
Contributor
|
@njm3754 it looks like you have some unsigned commits and some conflicts |
neerajmandal
force-pushed
the
t-nemand/invoke-function
branch
from
0e3c0b1 to
d11ed80
Compare
neerajmandal
force-pushed
the
t-nemand/invoke-function
branch
from
5fb52e2 to
dcdf2ae
Compare
added 2 commits
July 8, 2019 15:15
wbreza
approved these changes
Jul 9, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Added a few more comments - but otherwise looks good.
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
* feat: Invoke Plugin * feat: Invoke Plugin * Resolved conflicts * url encoder added & conflicts resoloved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke Plugin added
NOTE: Use the dev branch for deployment of functions. This branch has older version of deploy.
Example of how to invoke a function by passing data from command line.
sls invoke -f {functionName} --data '{"name": "test"}'Example of how to invoke a function by passing the file path from command line.
Note: The file containing the data should be present in the project directory (./project/data.json)
sls invoke -f {functionName} --path data.jsonResolves [AB#309]