This repository was archived by the owner on Dec 9, 2024. It is now read-only.
feat: add support for specifying resourceGroup in both cli and yaml #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in both cli and yaml
wbreza
reviewed
Jul 3, 2019
wbreza
approved these changes
Jul 3, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Looks great! Just a couple minor comments.
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
…189) when a name is specified in cli or yaml, serverless will use this name to create the resourceGroup instead of creating a name from convention. all underlying resources will still be created with a convention name.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a name is specified in cli or yaml, serverless will use this name to create the resourceGroup instead of creating a name from convention.
all underlying resources will still be created with a convention name.