This repository was archived by the owner on Dec 9, 2024. It is now read-only.
feat: Added feature to specify Azure subcription ID in CLI before deployment #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neerajmandal
changed the title
neerajmandal
changed the title
wbreza
reviewed
Jul 12, 2019
wbreza
suggested changes
Jul 12, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Looking good - just need some new unit tests.
| public hooks: { [eventName: string]: Promise<any> }; | ||
|
|
||
| public constructor(serverless: Serverless, private options: Serverless.Options) { | ||
| public constructor(serverless: Serverless, private options: Serverless.Options & AzureLoginOptions) { |
Contributor
There was a problem hiding this comment.
Needs new unit tests to validate this behavior.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature to specify subscription ID in the CLI which overrides any existing subscriptions ID and deploys the functions to the subscription specified by the user.
AB#360