This repository was archived by the owner on Dec 9, 2024. It is now read-only.
feat: Deploy pre-existing package with -p CLI option
#205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydiemho
approved these changes
Jul 18, 2019
|
|
||
| const defaultArtifact = path.join(".serverless", `${sls.service.getServiceName()}.zip`); | ||
|
|
||
| expect((FunctionAppService.prototype as any).sendFile).toBeCalledWith({ |
Contributor
There was a problem hiding this comment.
nit: I would extract the toBeCalledWith arguments out just so it's easier to read
| } | ||
| }, defaultArtifact); | ||
| const expectedArtifactName = service.getDeploymentName().replace("rg-deployment", "artifact"); | ||
| expect((AzureBlobStorageService.prototype as any).uploadFile).toBeCalledWith( |
Contributor
There was a problem hiding this comment.
nit: extract AzureBlobStorageService.prototype as any
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
- [x] Allow `-p` or `--package` param to specify package to deploy - [x] Log in before deployment rather than packaging - [x] Don't run deployment if local package does not exist Resolves [AB#500]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-por--packageparam to specify package to deployResolves [AB#500]