This repository was archived by the owner on Dec 9, 2024. It is now read-only.
refactor: Moved hooks requiring login to separate file #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarlow12
force-pushed
the
tabarlow/login-hooks
branch
from
d169324 to
3774ae0
Compare
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
Rather than changing the `AzureLoginPlugin` to add `"before:new:hook": this.login.bind(this)` every time a new hook is added that needs authentication, this allows for the hooks (without `before:`) to be placed in a separate file. These are loaded in the constructor of the plugin, which sets up the proper hooks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than changing the
AzureLoginPluginto add"before:new:hook": this.login.bind(this)every time a new hook is added that needs authentication, this allows for the hooks (withoutbefore:) to be placed in a separate file. These are loaded in the constructor of the plugin, which sets up the proper hooks.