Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Conversation

@pjlittle
Copy link
Contributor

When generating an APIM resource name, the service now
uses the shortened resource name, consistent with other resources.

@pjlittle pjlittle changed the title fix: api uses shortened region names fix: apim uses shortened region names Jul 19, 2019
@pjlittle pjlittle force-pushed the pjlittle/fix-apim-name branch from 07812be to 528a2d3 Compare July 19, 2019 22:20
@pjlittle pjlittle requested review from tbarlow12 and wbreza July 19, 2019 22:21
@coveralls
Copy link

coveralls commented Jul 19, 2019

Coverage Status

Coverage increased (+0.2%) to 84.184% when pulling 592e838 on pjlittle/fix-apim-name into 5d8162e on dev.

Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment otherwise good to go.

@pjlittle pjlittle force-pushed the pjlittle/fix-apim-name branch 2 times, most recently from c387c2c to 6d9a79f Compare July 22, 2019 13:43
@pjlittle
Copy link
Contributor Author

Bumped prerelease version in package.json

When generating an APIM resource name, the service now
uses the shortened resource name, consistent with other resources.
@pjlittle pjlittle force-pushed the pjlittle/fix-apim-name branch from 6d9a79f to 592e838 Compare July 22, 2019 14:51
@pjlittle pjlittle merged commit 9f69f24 into dev Jul 22, 2019
tbarlow12 pushed a commit that referenced this pull request Sep 13, 2019
When generating an APIM resource name, the service now
uses the shortened resource name, consistent with other resources.
@tbarlow12 tbarlow12 deleted the pjlittle/fix-apim-name branch September 16, 2019 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants