This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: Inject current environment variables to spawn process #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydiemho
approved these changes
Aug 1, 2019
src/services/offlineService.ts
Outdated
| const env = { | ||
| // Inherit environment from current process, most importantly, the PATH | ||
| ...process.env, | ||
| // Override any custom environment variables from serverless configuration |
Contributor
There was a problem hiding this comment.
is this saying custom env variables will override yml or vice versa?
Contributor
Author
There was a problem hiding this comment.
The env variables from serverless.yml are king :)
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
Add current process environment variables to spawned process, inherit `stdio` for spawned process, append `.cmd` if windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not able to repro
ENOENTerror yet, but this PR should help with debugging.PATHso that an executable can be found)See this stack overflow answer for more details.