This repository was archived by the owner on Dec 9, 2024. It is now read-only.
feat: Release and pre-release pipelines with publish script #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarlow12
force-pushed
the
tabarlow/release-azdo
branch
from
42c660c to
b56cf53
Compare
tbarlow12
force-pushed
the
tabarlow/release-azdo
branch
from
3b8e6b1 to
da75799
Compare
PIC123
approved these changes
Aug 8, 2019
pipelines/publish-release.yml
Outdated
|
|
||
| - task: Bash@3 | ||
| name: BumpNpmVersion | ||
| displayName: Bump NPM Prerelease Version |
Contributor
There was a problem hiding this comment.
Nit: would we want this to be just Release version?
| # GITHUB_ACCESS_TOKEN | ||
|
|
||
| PACKAGE_NAME=$1 | ||
| NPM_RELEASE_TYPE=${2-"prerelease"} |
Contributor
There was a problem hiding this comment.
Does this mean we will just have prerelease release types?
mydiemho
suggested changes
Aug 8, 2019
| filePath: ./scripts/version.sh | ||
| arguments: 'serverless/serverless-azure-functions' | ||
| env: | ||
| NPM_TOKEN: $(NPM_TOKEN) |
Contributor
There was a problem hiding this comment.
I would recommend creating Variable Groups in AzDO and referencing them here, so that you don't have to add the variables after pipeline creation
| filePath: ./scripts/publish.sh | ||
| arguments: 'prerelease' | ||
| env: | ||
| NPM_TOKEN: $(NPM_TOKEN) |
pipelines/publish-release.yml
Outdated
| filePath: ./scripts/version.sh | ||
| arguments: 'serverless/serverless-azure-functions' | ||
| env: | ||
| NPM_TOKEN: $(NPM_TOKEN) |
Contributor
There was a problem hiding this comment.
you need GITHUB_ACCESS_TOKEN here, not NPM_TOKEN
mydiemho
reviewed
Aug 8, 2019
scripts/version.sh
Outdated
| git checkout ${SOURCE_BRANCH_NAME} | ||
| echo Checked out branch: ${SOURCE_BRANCH_NAME} | ||
|
|
||
| NPM_VERSION=`npm version ${NPM_RELEASE_TYPE} -m "Update version ${NPM_RELEASE_TYPE} ***NO_CI***"` |
Contributor
There was a problem hiding this comment.
I would change the commit msg to "release: Bump ${NPM_RELEASE_TYPE} to %s NO_CI"
mydiemho
approved these changes
Aug 15, 2019
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
Pipelines for release and pre-release on merges to master and dev respectively. Dev branch will release a beta to NPM and Master will release a patch to NPM Resolves [AB#588]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipelines for release and pre-release on merges to master and dev respectively. Dev branch will release a beta to NPM and Master will release a patch to NPM
Pipelines not set up yet - still need approval from serverless org to run Azure DevOps on the repo
Resolves [AB#588]