This repository was archived by the owner on Dec 9, 2024. It is now read-only.
feat: Deploy function app code from blob storage URL #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
suggested changes
Aug 8, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Added a few questions regarding the order of operations with deployment / uploading artifacts, etc.
tbarlow12
force-pushed
the
tabarlow/deploy-from-blob
branch
from
2bba607 to
fe9ae05
Compare
wbreza
approved these changes
Aug 9, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Added a question about reusing SDK reference - otherwise looks good.
tbarlow12
force-pushed
the
tabarlow/deploy-from-blob
branch
from
fe9ae05 to
fd762b4
Compare
tbarlow12
commented
Aug 13, 2019
| }); | ||
|
|
||
| it("calls login if azure credentials are not set", async () => { | ||
| unsetServicePrincipalEnvVariables(); |
Contributor
Author
There was a problem hiding this comment.
This test was failing for some reason... Not sure how it got through the checks
Contributor
There was a problem hiding this comment.
huh, that's weird, I thought it had been added in the tests, good thing they work now then
PIC123
approved these changes
Aug 13, 2019
| }); | ||
|
|
||
| it("calls login if azure credentials are not set", async () => { | ||
| unsetServicePrincipalEnvVariables(); |
Contributor
There was a problem hiding this comment.
huh, that's weird, I thought it had been added in the tests, good thing they work now then
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
- [x] Allow configuration to specify whether or not to run from external package - [x] Set function app setting `WEBSITE_RUN_FROM_PACKAGE` with SAS URL of package from blob storage - [x] Get deployment configuration from `config.provider` - [x] Upload to blob storage before deployment if `runFromBlobUrl` is specified AB#488
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEBSITE_RUN_FROM_PACKAGEwith SAS URL of package from blob storageconfig.providerrunFromBlobUrlis specified