This repository was archived by the owner on Dec 9, 2024. It is now read-only.
feat: Handle SIGINT and cleanup offline files unless specified to skip #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
approved these changes
Aug 8, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Added some minor feedback - otherwise looks good :)
src/services/offlineService.ts
Outdated
| try { | ||
| await this.cleanup(); | ||
| } catch(e) {} | ||
| process.exit(); |
Contributor
There was a problem hiding this comment.
Consider moving the process.exit() into a finally block that can be reused for both condidtions.
try {
// Do all the things
} finally {
process.exit();
}
| lifecycleEvents: [ | ||
| "start" | ||
| ] | ||
| ], |
Contributor
There was a problem hiding this comment.
I'm assuming default behavior is to cleanup, correct?
pjlittle
approved these changes
Aug 8, 2019
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
#233) Cleans up offline files when user interrupts offline process. Allows user to skip cleanup with CLI option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up offline files when user interrupts offline process. Allows user to skip cleanup with CLI option.