This repository was archived by the owner on Dec 9, 2024. It is now read-only.
perf: Short-circuit deployment if ARM template hasn't changed #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
approved these changes
Aug 13, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Looks good overall - Added a few comments that I would like to see addressed before merged.
src/services/baseService.ts
Outdated
| this.log(JSON.stringify(object, null, 2)); | ||
| } | ||
|
|
||
| protected deepEqual(obj1: any, obj2: any) { |
Contributor
There was a problem hiding this comment.
I don't think deepEqual belongs as a function int the base service. Since it's an direct passthrough just have the consumer import and use it.
| * Get the most recent resource group deployment | ||
| */ | ||
| public async getLastDeployment() { | ||
| const deployments = await this.getDeployments(); |
Contributor
There was a problem hiding this comment.
Do these deployments contain timestamp? If so do we know it is in the proper order to pull latest version?
Contributor
Author
There was a problem hiding this comment.
They have always come in order of most recent to least recent. I can sort it by the official deployment timestamp (included in metadata, even if timestamp is not included in name)
tbarlow12
force-pushed
the
tabarlow/optimize-deployment
branch
2 times, most recently
from
ddf15d0 to
5b5f31f
Compare
neerajmandal
approved these changes
Aug 15, 2019
tbarlow12
force-pushed
the
tabarlow/optimize-deployment
branch
from
5b5f31f to
9e4ffd5
Compare
tbarlow12
force-pushed
the
tabarlow/optimize-deployment
branch
from
9e4ffd5 to
5f553f1
Compare
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
This checks the previously deployed template (including parameters/values) to see if the generated template has changed since the last deployment. If it has not changed, it will not deploy the ARM template. Since many cases will be code changes, this will drastically increase the speed of the average deployment. Resolves [AB#789]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks the previously deployed template (including parameters/values) to see if the generated template has changed since the last deployment. If it has not changed, it will not deploy the ARM template. Since many cases will be code changes, this will drastically increase the speed of the average deployment.
Resolves [AB#789]