Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Conversation

@medikoo
Copy link
Contributor

@medikoo medikoo commented Aug 16, 2019

With package.individually the expected function app zip file is not generated in form supported by a plugin.

In such case currently plugin just logs some error message as follows:

Function app zip file '/Users/medikoo/Projects/tests/serverless-azure/.serverless/test-azure-0x.zip' does not exist

but doesn't exit with an error, which gives a confusing impression.

This PR ensures that such scenario is reported with plugin error

@medikoo medikoo added the bug label Aug 16, 2019
@medikoo medikoo self-assigned this Aug 16, 2019
@medikoo medikoo requested review from mydiemho and tbarlow12 August 16, 2019 13:00
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbarlow12 tbarlow12 merged commit c79e27f into dev Aug 16, 2019
@tbarlow12 tbarlow12 deleted the medikoo/fix-deploy-error-handling branch September 16, 2019 16:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants