This repository was archived by the owner on Dec 9, 2024. It is now read-only.
feat: Specify Node.js runtime version in serverless.yml #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion is specified
Contributor
Author
|
Made some more changes. Now if the user does not specify runtime version the plugin throws an errors and just does not use the default value (10.14.1), Also added a new test case. |
…latest avaliable 10x version of nodejs
tbarlow12
suggested changes
Aug 20, 2019
tbarlow12
reviewed
Aug 22, 2019
| @@ -0,0 +1,63 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Can you document where you got this file? Maybe in a comment in functionApp.ts?
|
|
||
| //Searches for the latest verison | ||
| if(runtime.includes(".x")){ | ||
| let majorVersion = runtime.replace(/[^0-9]/g,""); |
Contributor
There was a problem hiding this comment.
Also, remove extra space
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
Specify Node.js runtime version in serverless.yml under provider. Throws an error for invalid Node.js version. AB#704
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify Node.js runtime version in serverless.yml under provider. Throws an error for invalid Node.js version.
AB#704