Update to new lifecycle hook, package to remove deprecation warning
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage invokes the following warning from SLS:
`Serverless: WARNING: Plugin AwsAddLogRetention uses deprecated hook before:deploy:createDeploymentArtifacts,
use package:createDeploymentArtifacts hook instead`
1) Update to new life cycle method
2) Update Tests
|
@ArtificerEntertainment could you take a look at this? It would cleanup some noise during serverless deployments and comply with the newer lifecycle stages. |
Contributor
Author
|
@ArtificerEntertainment any word on this pull request please? thanks. |
|
👍 |
|
Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage invokes the following warning from SLS:
Serverless: WARNING: Plugin AwsAddLogRetention uses deprecated hook before:deploy:createDeploymentArtifacts, use package:createDeploymentArtifacts hook insteadpackageMaking this change removes the deprecation warning when deploying.