Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

fix broken windows path #247

Merged
merged 6 commits into from
Sep 18, 2018
Merged

fix broken windows path #247

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
97f378c
fix broken windows path
Sep 17, 2018
ff29e77
remove quote_single as it is done in dockerPathForWin
Sep 17, 2018
c9c04e7
forgot to pass options
Sep 17, 2018
63b2195
shorten line
Sep 17, 2018
9bb5412
yarn format
Sep 17, 2018
cc098a4
Merge branch 'master' into master
dschep Sep 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/pip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,12 @@ function installRequirements(targetFolder, serverless, options) {
serverless.cli.log(`Docker Image: ${dockerImage}`);

// Prepare bind path depending on os platform
const bindPath = getBindPath(serverless, targetFolder);
const bindPath = dockerPathForWin(
options,
getBindPath(serverless, targetFolder)
);

cmdOptions = ['run', '--rm', '-v', quote_single(`${bindPath}:/var/task:z`)];
cmdOptions = ['run', '--rm', '-v', `${bindPath}:/var/task:z`];
if (options.dockerSsh) {
// Mount necessary ssh files to work with private repos
cmdOptions.push(
Expand Down