Skip to content

Conversation

@medikoo
Copy link
Contributor

@medikoo medikoo commented Mar 3, 2021

Continuation of #9060, where patch was applied only behind SLS_DEBUG flag, that shouldn't be the case

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #9063 (41d75b7) into master (7ba7bb3) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9063   +/-   ##
=======================================
  Coverage   87.14%   87.15%           
=======================================
  Files         288      288           
  Lines       11026    11026           
=======================================
+ Hits         9609     9610    +1     
+ Misses       1417     1416    -1     
Impacted Files Coverage Δ
lib/Serverless.js 92.46% <50.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba7bb3...e6abc4e. Read the comment docs.

@pgrzesik pgrzesik self-requested a review March 3, 2021 14:03
pgrzesik
pgrzesik previously approved these changes Mar 3, 2021
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo force-pushed the 0303-variables-properly-fix-variable-access branch from 2fada5d to e6abc4e Compare March 3, 2021 14:08
@medikoo medikoo requested a review from pgrzesik March 3, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants