Address shortcomings in AWS API Gateway validation schema #9894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9894 +/- ##
=======================================
Coverage 86.21% 86.21%
=======================================
Files 329 329
Lines 12827 12827
=======================================
Hits 11059 11059
Misses 1768 1768
Continue to review full report at Codecov.
|
medikoo
approved these changes
Aug 30, 2021
Contributor
medikoo
left a comment
medikoo
left a comment
There was a problem hiding this comment.
I don't think there's a problem as the only issue there was with mappedValue property and required property still has to be provided, so I don't think we have any issue there.
Indeed, didn't read that correctly, good catch 👍
Great to see we can solve it right away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9885
@medikoo As for your last comment, I don't think there's a problem as the only issue there was with
mappedValueproperty andrequiredproperty still has to be provided, so I don't think we have any issue there.