Skip to content

Fix #243 - Implement redirect parameter in HTTP and OpenAPI #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

Fix #243 - Implement redirect parameter in HTTP and OpenAPI #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions model/task_call.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ type HTTPArguments struct {
Body json.RawMessage `json:"body,omitempty"`
Query map[string]interface{} `json:"query,omitempty"`
Output string `json:"output,omitempty" validate:"omitempty,oneof=raw content response"`
Redirect bool `json:"redirect,omitempty"`
}

type CallOpenAPI struct {
Expand All @@ -51,6 +52,7 @@ type OpenAPIArguments struct {
Parameters map[string]interface{} `json:"parameters,omitempty"`
Authentication *ReferenceableAuthenticationPolicy `json:"authentication,omitempty"`
Output string `json:"output,omitempty" validate:"omitempty,oneof=raw content response"`
Redirect bool `json:"redirect,omitempty"`
}

type CallGRPC struct {
Expand Down
20 changes: 14 additions & 6 deletions model/task_call_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ func TestCallHTTP_MarshalJSON(t *testing.T) {
Query: map[string]interface{}{
"q": "search",
},
Output: "content",
Output: "content",
Redirect: true,
},
}

Expand All @@ -64,7 +65,8 @@ func TestCallHTTP_MarshalJSON(t *testing.T) {
"endpoint": "http://example.com",
"headers": {"Authorization": "Bearer token"},
"query": {"q": "search"},
"output": "content"
"output": "content",
"redirect": true
}
}`, string(data))
}
Expand All @@ -83,7 +85,8 @@ func TestCallHTTP_UnmarshalJSON(t *testing.T) {
"endpoint": "http://example.com",
"headers": {"Authorization": "Bearer token"},
"query": {"q": "search"},
"output": "content"
"output": "content",
"redirect": true
}
}`

Expand All @@ -102,6 +105,7 @@ func TestCallHTTP_UnmarshalJSON(t *testing.T) {
assert.Equal(t, map[string]string{"Authorization": "Bearer token"}, callHTTP.With.Headers)
assert.Equal(t, map[string]interface{}{"q": "search"}, callHTTP.With.Query)
assert.Equal(t, "content", callHTTP.With.Output)
assert.Equal(t, true, callHTTP.With.Redirect)
}

func TestCallOpenAPI_MarshalJSON(t *testing.T) {
Expand Down Expand Up @@ -133,7 +137,8 @@ func TestCallOpenAPI_MarshalJSON(t *testing.T) {
Authentication: &ReferenceableAuthenticationPolicy{
Use: &authPolicy,
},
Output: "content",
Output: "content",
Redirect: true,
},
}

Expand All @@ -160,7 +165,8 @@ func TestCallOpenAPI_MarshalJSON(t *testing.T) {
"authentication": {
"use": "my-auth"
},
"output": "content"
"output": "content",
"redirect": true
}
}`, string(data))
}
Expand All @@ -187,7 +193,8 @@ func TestCallOpenAPI_UnmarshalJSON(t *testing.T) {
"authentication": {
"use": "my-auth"
},
"output": "content"
"output": "content",
"redirect": true
}
}`

Expand All @@ -207,6 +214,7 @@ func TestCallOpenAPI_UnmarshalJSON(t *testing.T) {
assert.Equal(t, map[string]interface{}{"param1": "value1", "param2": "value2"}, callOpenAPI.With.Parameters)
assert.Equal(t, "my-auth", *callOpenAPI.With.Authentication.Use)
assert.Equal(t, "content", callOpenAPI.With.Output)
assert.Equal(t, true, callOpenAPI.With.Redirect)
}

func TestCallGRPC_MarshalJSON(t *testing.T) {
Expand Down
Loading