[Fix #898] RunShell minor improvements #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
commented
Oct 24, 2025
| softly.assertThat(outputModel.asText().get()).isNotEmpty(); | ||
| softly.assertThat(outputModel.asText().get()).contains("ls: cannot access"); | ||
| softly.assertThat(outputModel.asText().get()).contains("No such file or directory"); | ||
| softly.assertThat(outputModel.asText().get()).contains("ls"); |
There was a problem hiding this comment.
This test only worked if the locale of the OS was english, so I do the trick of just checking that the stderr contains "ls"
Enable test only in linux (till we implement for other Operating systems) Run asynchrnously Signed-off-by: fjtirado <ftirados@redhat.com>
fjtirado
force-pushed
the
Run_shell_minor_improvements
branch
from
e01d199 to
13f154f
Compare
fjtirado
commented
Oct 24, 2025
| return input; | ||
| } | ||
|
|
||
| return taskConfiguration.isAwait() |
There was a problem hiding this comment.
yes, this one was not needed, but I love ternary operator and could not refrain, sorry ;)
fjtirado
commented
Oct 24, 2025
| if (entry.getValue() == null) { | ||
| commandBuilder.append(" ").append(argKey); | ||
| continue; | ||
| commandBuilder |
There was a problem hiding this comment.
I wanted to avoid the use of continue, which in this case was possible
fjtirado
commented
Oct 24, 2025
| : shellCommand; | ||
|
|
||
| StringBuilder commandBuilder = new StringBuilder(command); | ||
| StringBuilder commandBuilder = |
There was a problem hiding this comment.
Just saving a variable declaration
mcruzdev
reviewed
Oct 24, 2025
| ProcessBuilder processBuilder = this.processBuilderSupplier.apply(workflowContext, taskContext); | ||
| return CompletableFuture.completedFuture( | ||
| this.shellResultSupplier.apply(taskContext, input, processBuilder)); | ||
| return CompletableFuture.supplyAsync( |
There was a problem hiding this comment.
I forgot about that, nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable test only in linux (till we implement for other Operating systems)
Run asynchronously