feat: baseline run:script, run:container and run:shell to support stdin and argv #1128
+522
−161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hey there!! The PR as promised. A little delayed. I added a few examples too. Not sure if I should put in 1.1 as dsl version in the examples or not. Let me know! Thanks |
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io> Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io> Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io> Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io> Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io> Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io> Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Signed-off-by: hiren <20088337+hirenr@users.noreply.github.com>
Author
|
Recreating another as this is polluted |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify parts of this PR update:
Discussion or Issue link:
Slack Discussion Link
What this PR does:
Update the run:* syntax to have a unified structure. Introduced parameters
stdin, and updatedarguments.argumentsasstring[]passed as CLI args torun:shell/run:container/run:scriptunderlying commandPass
stdinstring via a newstringproperty to the run:shell / run:container / run:script underlying command!Additional information:
The advantages to the following are: