-
Notifications
You must be signed in to change notification settings - Fork 3
fix: Updated dependencies to be consistent and compatible with Dart 3.3 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe changes update the YAML parsing implementation in the codebase by switching the dependency from Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lib/src/config/json_yaml_document.dart (1)
21-21: Handle empty YAML source consistently
JsonYamlDocument.fromJsonguards against empty input by returningnull, butloadYaml('')may throw or yield unexpected results. Consider matching the JSON constructor’s behavior:_document = yamlSource.isEmpty ? null : loadYaml(yamlSource);This ensures both constructors behave uniformly when given an empty string.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
lib/src/config/json_yaml_document.dart(2 hunks)pubspec.yaml(2 hunks)
🔇 Additional comments (3)
pubspec.yaml (2)
15-15: Bump Dart SDK constraint to ^3.3.0
Raising the minimum SDK version aligns the package with its updated dependencies and ensures compatibility with Serverpod.
28-28: Switch dependency fromyaml_codectoyaml
Usingyaml: ^3.1.2avoids the unnecessary Dart 3.5 requirement imposed byyaml_codecand resolves the compatibility issue.lib/src/config/json_yaml_document.dart (1)
4-4: Importyamlinstead ofyaml_codec
Updating topackage:yaml/yaml.dartcorrectly reflects the change inpubspec.yaml. Ensure that any leftover references toyaml_codecare removed.
Isakdl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The yaml_coded dependency required Dart 3.5 which is not compatible with the current Serverpod framework, and this package should not enforce a minimum Dart version unless necessary. The yaml_codec package is therefore replaced with the yaml package.
The minimum Dart version was bumped from 3.1 to 3.3 since several of the dependencies of this package actually do require it. This is compatible with Serverpod.
Summary by CodeRabbit