Skip to content

Optimize .Query.All<> implementation #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2025
Merged

Optimize .Query.All<> implementation #410

merged 3 commits into from
Oct 25, 2025

Conversation

@SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Oct 24, 2025 •
edited
Loading

Generic form .Query.All<> can be implemented on generic Traits<T>.RootCallExpression instead of cache lookup

Also:

  • Make the RootCallExpressionsCache static as it is domain-independent
  • Remove provider null-checking. It is already ensured by the caller

@SergeiPavlov SergeiPavlov merged commit f2bb2c2 into master-servicetitan Oct 25, 2025
34 of 35 checks passed
@SergeiPavlov SergeiPavlov deleted the QueryAll branch October 25, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@botinko botinko botinko approved these changes

@snaumenko-st snaumenko-st Awaiting requested review from snaumenko-st

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SergeiPavlov @botinko