Revert "Add "contents" and "scroll-position" keywords to local names" #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6089ea4.
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit cc2f8db has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Mar 9, 2017
Revert "Add "contents" and "scroll-position" keywords to local names" This reverts PR #256 / commit 6089ea4. Turns out these atoms are needed in `servo_atoms::Atom`, not `LocalName`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/257) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
Member
Author
|
I’ve realized after submitting this that removing static atoms is technically a breaking change, and v0.2.1 is already on crates.io with them. @nox, what approach would you prefer?
|
Contributor
|
I think yanking would be the correct approach here. |
Member
Author
|
I tend to agree. Yanked. (We can still unyank or/and do 0.3.0.) |
Contributor
|
@SimonSapin I think we are supposed to release a 0.2.2 without the change that we yanked, otherwise even crates.io is confused. |
Member
Author
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #256 / commit 6089ea4.
Turns out these atoms are needed in
servo_atoms::Atom, notLocalName.This change is