Update string-cache in html5ever-atoms. #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
r? @nox |
Member
Author
|
(Let me know if this should be breaking, but I don't think so) |
Contributor
|
It's a breaking change because |
Contributor
|
So it's a breaking change in |
Member
Author
|
Sure, but its API isn't changed, right? Oh, I guess you could have another older string_cache or something like that/ |
Contributor
|
Yes, using a type from a dependency with a different breaking version than before is a change in API, because |
Member
Author
|
Ammended |
Contributor
|
@bors-servo r+ |
Contributor
|
📌 Commit fe71bd8 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Apr 7, 2017
Update string-cache in html5ever-atoms. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/264) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is