Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow failures on linux cross1 until travis fixes infra issues on GCE #274

Merged
merged 1 commit into from Mar 24, 2016

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Mar 24, 2016

r? @edunham

If this succeeds (I am always confused about the allow_failures syntax for this case), we can land all of the stuff that's failing due to the issue with the missing Ubuntu packages 'g++-arm-linux-gnueabihf' & 'g++-aarch64-linux-gnu' from the GCE instances.


This change is Reviewable

@edunham
Copy link
Contributor

edunham commented Mar 24, 2016

@bors-servo r+

We'll just have to be extra careful in manual review to examine the logs from linux-cross-1 till this change gets reverted.

@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

📌 Commit aa84355 has been approved by edunham

@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

Testing commit aa84355 with merge fd52dc4...

bors-servo added a commit that referenced this pull request Mar 24, 2016
Allow failures on linux cross1 until travis fixes infra issues on GCE

r? @edunham

If this succeeds (I am always confused about the allow_failures syntax for this case), we can land all of the stuff that's failing due to the issue with the missing Ubuntu packages 'g++-arm-linux-gnueabihf' & 'g++-aarch64-linux-gnu' from the GCE instances.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/274)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 24, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit aa84355 into servo:master Mar 24, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request Apr 5, 2016
…-arm-g++-packages, r=larsbergstrom

Re-engage servo-linux-cross1 on Travis

Upstream has released new packages for Ubuntu Trusty which resolve
the installation conflicts encountered when installing the ARM g++ packages.

See https://bugs.launchpad.net/ubuntu/+source/gcc-4.8-armhf-cross/+bug/1557205/comments/16
for a comment confirming release of the upstream fix.

This reverts commit aa84355 which was part of #274.

Closes #280.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/291)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.