Skip to content

Have check_allowed_in read gPropertyEabled table directly #17913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2017
Merged

Have check_allowed_in read gPropertyEabled table directly #17913

merged 1 commit into from
Jul 29, 2017

Conversation

@upsuper
Copy link
Contributor

@upsuper upsuper commented Jul 29, 2017 •
edited by larsbergstrom
Loading

This is the Servo side change of bug 1381690.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/properties/properties.mako.rs
  • @canaltinova: components/style/gecko/generated/bindings.rs, components/style/properties/properties.mako.rs
  • @emilio: components/style/gecko/generated/bindings.rs, components/style/properties/properties.mako.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 29, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@upsuper
Copy link
Contributor Author

upsuper commented Jul 29, 2017

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

📌 Commit 5be5d49 has been approved by Manishearth

@highfive highfive assigned Manishearth and unassigned nox Jul 29, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 29, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 5be5d49 with merge b47e187...

bors-servo pushed a commit that referenced this pull request Jul 29, 2017
Auto merge of #17913 - upsuper:prop-enabled, r=Manishearth
b47e187 
Have check_allowed_in read gPropertyEabled table directly

This is the Servo side change of [bug 1381690](https://bugzilla.mozilla.org/show_bug.cgi?id=1381690).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17913)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing b47e187 to master...

@bors-servo bors-servo merged commit 5be5d49 into servo:master Jul 29, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 29, 2017
@upsuper upsuper deleted the prop-enabled branch July 29, 2017 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Manishearth Manishearth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@upsuper @highfive @bors-servo @nox @Manishearth