Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event::new should initialize cancelable to false. #3855

Closed
Ms2ger opened this issue Oct 30, 2014 · 0 comments · Fixed by #3870
Closed

Event::new should initialize cancelable to false. #3855

Ms2ger opened this issue Oct 30, 2014 · 0 comments · Fixed by #3870
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-wrong An incorrect behaviour is observed.

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 30, 2014

Blocks #2185.
@Ms2ger Ms2ger added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-wrong An incorrect behaviour is observed. labels Oct 30, 2014
@mitchelljustin mitchelljustin mentioned this issue Nov 2, 2014
Merged
bors-servo pushed a commit that referenced this issue Nov 2, 2014
auto merge of #3870 : mvanderh/servo/master, r=Ms2ger
9b2dae5 
Fixes #3855.

I'm not sure if this is the right place to set `cancelable`. If changing the default value in `Event::new_inherited` is not satisfactory, it will be possible to set the `Cell`'s value to `false` in `Event::new` itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-wrong An incorrect behaviour is observed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initialize 'cancelable' to false in Event::new_inherited.
1 participant
@Ms2ger