Add preferences to enable/disable the JITs #10325

stjepang · 2016-04-01T00:48:02Z

When creating a runtime (script.rs), we check prefs and then enable or
disable the JITs (Baseline and Ion) accordingly.

Closes #10278.

This change is

highfive · 2016-04-01T00:48:06Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/script_thread.rs

highfive · 2016-04-01T00:48:07Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify script code, but no tests are modified. Please consider adding a test!

paulrouget · 2016-04-01T03:29:18Z

We should start documenting these preferences somewhere.

mbrubeck · 2016-04-01T04:18:51Z

Could you add these to resources/prefs.json with the default value true? This will provide one easy way to discover and flip these prefs. Thanks!

Also, ./mach test-tidy failed:

./components/script/script_thread.rs:61: use statement is not in alphabetical order
    expected: js::jsapi::{JSObject, SetPreserveWrapperCallback}
    found: js::jsapi::RuntimeOptionsRef

bors-servo · 2016-04-02T01:44:25Z

☔ The latest upstream changes (presumably #10336) made this pull request unmergeable. Please resolve the merge conflicts.

mbrubeck · 2016-04-04T17:55:30Z

components/script/script_thread.rs

+        unsafe {
+            let rt_opts = RuntimeOptionsRef(runtime.rt());
+            is_baseline_enabled.map(|val| (*rt_opts).set_baseline_(val));
+            is_ion_enabled.map(|val| (*rt_opts).set_ion_(val));


I missed this before: Could you change this to use if let instead of .map()? This is purely a style preference; we find it more readable than map in cases where the return value isn't used.

r=mbrubeck with that change


        Add preferences to enable/disable the JITs

When creating a runtime (script.rs), we check prefs and then enable or disable the JITs (Baseline and Ion).

mbrubeck · 2016-04-04T20:46:01Z

@bors-servo r+

mbrubeck · 2016-04-04T20:46:01Z

@bors-servo r+

bors-servo · 2016-04-04T20:46:01Z

📌 Commit 3ad7119 has been approved by mbrubeck

bors-servo · 2016-04-04T20:46:01Z

📌 Commit 3ad7119 has been approved by mbrubeck

mbrubeck · 2016-04-04T20:46:26Z

@bors-servo r+

bors-servo · 2016-04-04T20:46:27Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #10391

bors-servo · 2016-04-04T20:46:27Z

📌 Commit 3ad7119 has been approved by mbrubeck

mbrubeck · 2016-04-04T20:46:40Z

@bors-servo r+

bors-servo · 2016-04-04T20:46:41Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #10391

bors-servo · 2016-04-04T20:46:42Z

📌 Commit 3ad7119 has been approved by mbrubeck

bors-servo · 2016-04-04T21:14:10Z

⌛ Testing commit 3ad7119 with merge 60e5755...


        Auto merge of #10325 - stjepang:pref-disable-jit, r=mbrubeck

Add preferences to enable/disable the JITs When creating a runtime (script.rs), we check prefs and then enable or disable the JITs (Baseline and Ion) accordingly. Closes #10278.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10325)

bors-servo · 2016-04-04T21:57:13Z

💔 Test failed - linux-rel

mbrubeck · 2016-04-04T22:36:55Z

@bors-servo retry

#10398

bors-servo · 2016-04-04T22:40:28Z

⚡ Previous build results for android, arm32, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor are reusable. Rebuilding only linux-rel...

bors-servo · 2016-04-04T23:22:23Z

💔 Test failed - linux-rel

mbrubeck · 2016-04-05T00:06:26Z

@bors-servo retry

#10398

bors-servo · 2016-04-05T00:20:14Z

⌛ Testing commit 3ad7119 with merge 863c905...


        Auto merge of #10325 - stjepang:pref-disable-jit, r=mbrubeck

Add preferences to enable/disable the JITs When creating a runtime (script.rs), we check prefs and then enable or disable the JITs (Baseline and Ion) accordingly. Closes #10278.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10325)

bors-servo · 2016-04-05T01:17:37Z

☀️ Test successful - android, arm32, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor

highfive assigned mbrubeck Apr 1, 2016

highfive added the S-awaiting-review label Apr 1, 2016

mbrubeck added S-needs-code-changes S-fails-tidy and removed S-awaiting-review labels Apr 1, 2016

highfive added S-awaiting-review and removed S-needs-code-changes labels Apr 1, 2016

highfive added the S-needs-rebase label Apr 2, 2016

stjepang force-pushed the stjepang:pref-disable-jit branch from ff5880f to 70c20eb Apr 2, 2016

jdm removed S-fails-tidy S-needs-rebase labels Apr 2, 2016

mbrubeck reviewed Apr 4, 2016
View changes

jdm added S-needs-code-changes and removed S-awaiting-review labels Apr 4, 2016

highfive added S-awaiting-review and removed S-needs-code-changes labels Apr 4, 2016

stjepang force-pushed the stjepang:pref-disable-jit branch from 3f8c5db to 23a2a75 Apr 4, 2016

Add preferences to enable/disable the JITs

Loading status checks…

3ad7119

When creating a runtime (script.rs), we check prefs and then enable or disable the JITs (Baseline and Ion).

stjepang force-pushed the stjepang:pref-disable-jit branch from 23a2a75 to 3ad7119 Apr 4, 2016

highfive removed S-awaiting-review labels Apr 4, 2016

highfive added the S-awaiting-merge label Apr 4, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Apr 4, 2016

highfive added the S-tests-failed label Apr 4, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Apr 5, 2016

bors-servo merged commit 3ad7119 into servo:master Apr 5, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Apr 5, 2016

bors-servo mentioned this pull request Apr 5, 2016

Refactors some entities from script_thread into script_runtime #10342

Merged

servo / servo

Add preferences to enable/disable the JITs #10325

Add preferences to enable/disable the JITs #10325

stjepang commented Apr 1, 2016

highfive commented Apr 1, 2016

highfive commented Apr 1, 2016

paulrouget commented Apr 1, 2016

mbrubeck commented Apr 1, 2016

bors-servo commented Apr 2, 2016

This comment has been minimized.

mbrubeck commented Apr 4, 2016

mbrubeck commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

mbrubeck commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

mbrubeck commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

mbrubeck commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

mbrubeck commented Apr 5, 2016

bors-servo commented Apr 5, 2016

bors-servo commented Apr 5, 2016

servo / servo

Join GitHub today

Add preferences to enable/disable the JITs #10325

Add preferences to enable/disable the JITs #10325

Conversation

stjepang commented Apr 1, 2016

highfive commented Apr 1, 2016

highfive commented Apr 1, 2016

paulrouget commented Apr 1, 2016

mbrubeck commented Apr 1, 2016

bors-servo commented Apr 2, 2016

This comment has been minimized.

mbrubeck Apr 4, 2016

mbrubeck commented Apr 4, 2016

mbrubeck commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

mbrubeck commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

mbrubeck commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

mbrubeck commented Apr 4, 2016

bors-servo commented Apr 4, 2016

bors-servo commented Apr 4, 2016

mbrubeck commented Apr 5, 2016

bors-servo commented Apr 5, 2016

bors-servo commented Apr 5, 2016