switched to rustls for certificate verification #15329
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the connection code to use rustls and webpki for verification.
There is possibly a performance hit, but this is the first step to reducing dependence on openssl. I've done some investigation on performance (planning on more).
Performance evaluation: I connected to 13 https sites using rustls::verify_server_cert, rustls::parallel_verify_server_cert, and the openssl code currently used in servo.
Average time to establish a connection using:
This is blocked on rustls/rustls#47 and blocks #15010
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is