Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upswitched to rustls for certificate verification #15329
Closed
+422
−216
Conversation
highfive
commented
Feb 1, 2017
|
Heads up! This PR modifies the following files:
|
|
r? @jdm |
Closed
|
What's blocking this? |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
avadacatavra commentedFeb 1, 2017
•
edited by larsbergstrom
Changed the connection code to use rustls and webpki for verification.
There is possibly a performance hit, but this is the first step to reducing dependence on openssl. I've done some investigation on performance (planning on more).
Performance evaluation: I connected to 13 https sites using rustls::verify_server_cert, rustls::parallel_verify_server_cert, and the openssl code currently used in servo.
Average time to establish a connection using:
This is blocked on ctz/rustls#47 and blocks #15010
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is