Skip to content

Derive ToCss for computed LengthOrPercentage types #17338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2017
Merged

Derive ToCss for computed LengthOrPercentage types #17338

merged 2 commits into from
Jun 15, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Jun 15, 2017 •
edited by larsbergstrom
Loading

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/computed/position.rs, components/style/gecko/conversions.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/values/specified/calc.rs, components/style/values/specified/length.rs and 7 more
  • @emilio: components/layout/display_list_builder.rs, components/style/values/computed/position.rs, components/style/gecko/conversions.rs, components/layout/block.rs, components/style/gecko_bindings/sugar/ns_css_value.rs and 15 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 15, 2017
@nox
Copy link
Contributor Author

nox commented Jun 15, 2017

r? @emilio

@ghost
Copy link

ghost commented Jun 15, 2017

r=me after tidy fix.

./components/style/gecko_bindings/sugar/ns_css_value.rs:19: use statement is not in alphabetical order
    expected: values::specified::url::SpecifiedUrl
    found: values::specified::length::Percentage

@ghost ghost added S-fails-tidy `./mach test-tidy` reported errors. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 15, 2017
@nox nox force-pushed the derive-all-the-things branch from 9b8dfbe to 16afa6e Compare June 15, 2017 14:59
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 15, 2017
@jdm
Copy link
Member

jdm commented Jun 15, 2017

@bors-servo: r=emilio,waffles

@bors-servo
Copy link
Contributor

📌 Commit 16afa6e has been approved by emilio,waffles

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 15, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 16afa6e with merge 0142d19...

bors-servo pushed a commit that referenced this pull request Jun 15, 2017
Auto merge of #17338 - servo:derive-all-the-things, r=emilio,waffles
0142d19 
Derive ToCss for computed LengthOrPercentage types

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17338)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio,waffles
Pushing 0142d19 to master...

@bors-servo bors-servo merged commit 16afa6e into master Jun 15, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilio emilio emilio approved these changes

Assignees

@emilio emilio

Labels

S-fails-tidy `./mach test-tidy` reported errors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nox @highfive @jdm @bors-servo @emilio