Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive ToCss for computed LengthOrPercentage types #17338

Merged
merged 2 commits into from Jun 15, 2017

Conversation

@nox
Copy link
Member

commented Jun 15, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jun 15, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/computed/position.rs, components/style/gecko/conversions.rs, components/style/gecko_bindings/sugar/ns_css_value.rs, components/style/values/specified/calc.rs, components/style/values/specified/length.rs and 7 more
  • @emilio: components/layout/display_list_builder.rs, components/style/values/computed/position.rs, components/style/gecko/conversions.rs, components/layout/block.rs, components/style/gecko_bindings/sugar/ns_css_value.rs and 15 more
@nox

This comment has been minimized.

Copy link
Member Author

commented Jun 15, 2017

r? @emilio

@wafflespeanut

This comment has been minimized.

Copy link
Member

commented Jun 15, 2017

r=me after tidy fix.

./components/style/gecko_bindings/sugar/ns_css_value.rs:19: use statement is not in alphabetical order
    expected: values::specified::url::SpecifiedUrl
    found: values::specified::length::Percentage
@nox nox force-pushed the derive-all-the-things branch from 9b8dfbe to 16afa6e Jun 15, 2017
@emilio
emilio approved these changes Jun 15, 2017
@jdm

This comment has been minimized.

Copy link
Member

commented Jun 15, 2017

@bors-servo: r=emilio,waffles

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2017

📌 Commit 16afa6e has been approved by emilio,waffles

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2017

⌛️ Testing commit 16afa6e with merge 0142d19...

bors-servo added a commit that referenced this pull request Jun 15, 2017
Derive ToCss for computed LengthOrPercentage types

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17338)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2017

@bors-servo bors-servo merged commit 16afa6e into master Jun 15, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.