Windows support for the --nightly | -n flag to mach run commands. #20122

o0Ignition0o · 2018-02-26T06:49:07Z

Add windows support to the -n flag.

Followup to #19947 , this PR will add windows support to the -n flag.
This is part of step two for #19505

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #__ (github issue number if applicable).

The feature does not work just yet, I'm able to download and extract the archive, but it's not running the executable yet.
@tigercosmos might be a good reviewer on this one :)

There are tests for these changes OR
These changes do not require tests because they're part of a ./mach command.

This change is

highfive · 2018-02-26T06:49:13Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

highfive · 2018-02-26T06:49:13Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/command_base.py, python/servo/post_build_commands.py

tigercosmos · 2018-02-26T13:20:41Z

I guess we should merge #19947, and then go to work on this. The two code are overlaid.

o0Ignition0o · 2018-02-26T15:00:49Z

Yeah definitely ! :)

jdm

This looks like a good improvement on the original PR. Thanks!

jdm · 2018-03-05T18:05:50Z

python/servo/command_base.py

+            print("Extracting to {} ...".format(destination_folder))
+            if is_windows():
+                command = 'msiexec /a {} /qn TARGETDIR={}' \
+                    .format(os.path.join(nightlies_folder, destination_file), destination_folder)


Let's use this formatting instead:

command = 'msiexec /a {} /qn TARGETDIR={}'.format( path.join(...), destination_folder)

jdm · 2018-03-05T18:05:53Z

python/servo/command_base.py

+        bin_folder = path.join(destination_folder, "servo")
+        if is_windows():
+            bin_folder = path.join(destination_folder, "PFiles", "Mozilla research", "Servo Tech Demo")
+        print(path.join(bin_folder, "servo{}".format(BIN_SUFFIX)))


Do we still need this?

I think I could extract the .msi archive to %temp% and just keep the .exe file instead :)

I was asking about the print, but it's worth a try!

Oh I see, no it's debug code I use (I seem to get the right path but when I try to ./mach run with a path to the executable it just won't ^^
I guess as soon as I figure it out I'll remove the WIP tag on the PR (Probably this weekend :))

bors-servo · 2018-03-07T05:50:03Z

☔ The latest upstream changes (presumably #19947) made this pull request unmergeable. Please resolve the merge conflicts.

o0Ignition0o · 2018-03-11T16:53:41Z

This should be reviewable now.
Please not I have not been able to run the executable on my windows virtual machine (but I still couldn't do so when downloading and running it manually). So extra caution / trying to run it on windows would be more than appreciated ^^'

The command to run would be

./mach run -n 2018-02-25 https://mozilla.org

jdm · 2018-03-11T17:03:21Z

Is there a difference if you run a windows nightly since March 1? There was a two month period in which we broke nightlies on windows at startup.

o0Ignition0o · 2018-03-11T17:55:14Z

I got the same result as I ran

PS C:\Users\jerem\Documents\Mozilla\servo> .\mach.bat run -n 2018-03-08 https://mozilla.org

The window seems to open and closes instantly.
The same behaviour happens when I run the Windows Build ZIP from https://download.servo.org/ so I'm pretty convinced it has to do with my setup
Edit :

Failed to create window.: NoAvailablePixelFormat (thread main, at libcore\result.rs:916)

This is definitely related to my VM setup x)

jdm · 2018-03-16T16:55:55Z

Let's go ahead and merge this. If anybody tests it in a non-VM environment they can let us know how it goes.
@bors-servo r+

bors-servo · 2018-03-16T16:55:56Z

📌 Commit a132a9b has been approved by jdm

bors-servo · 2018-03-16T16:56:04Z

⌛ Testing commit a132a9b with merge f5c1f51...

@tigercosmos

Windows support for the --nightly | -n flag to mach run commands.  Add windows support to the -n flag. --- Followup to #19947 , this PR will add windows support to the -n flag. This is part of step two for #19505  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). The feature does not work just yet, I'm able to download and extract the archive, but it's not running the executable yet. @tigercosmos might be a good reviewer on this one :)  - [ ] There are tests for these changes OR - [X] These changes do not require tests because they're part of a ./mach command.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20122)

bors-servo · 2018-03-16T17:49:12Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing f5c1f51 to master...

./mach run -n on mac os.  Add macos support to the -n flag. Followup to #20122 , this PR will add macos support to the -n flag. This is part of step two for #19505 ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable).  - [ ] There are tests for these changes OR - [X] These changes do not require tests because this mach command does not build anything    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22387)

highfive assigned pcwalton Feb 26, 2018

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 26, 2018

o0Ignition0o force-pushed the mach_run_nightly_windows branch from 336a10b to b97aa8e Compare February 26, 2018 07:04

jdm assigned jdm and unassigned pcwalton Feb 26, 2018

jdm requested changes Mar 5, 2018

View reviewed changes

jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 5, 2018

highfive added the S-needs-rebase There are merge conflict errors. label Mar 7, 2018

o0Ignition0o force-pushed the mach_run_nightly_windows branch from b97aa8e to 887fcf6 Compare March 11, 2018 16:07

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Mar 11, 2018

Add Windows support to the --nightly | -n flag.

a132a9b

o0Ignition0o force-pushed the mach_run_nightly_windows branch from 887fcf6 to a132a9b Compare March 11, 2018 16:50

o0Ignition0o changed the title ~~[WIP] Windows support for the --nightly | -n flag to mach run commands.~~ Windows support for the --nightly | -n flag to mach run commands. Mar 11, 2018

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Mar 16, 2018

bors-servo merged commit a132a9b into servo:master Mar 16, 2018

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 16, 2018

o0Ignition0o deleted the mach_run_nightly_windows branch December 8, 2018 12:51

o0Ignition0o mentioned this pull request Dec 8, 2018

./mach run -n on mac os. #22387

Merged

5 tasks

Uh oh!

Windows support for the --nightly | -n flag to mach run commands. #20122

Windows support for the --nightly | -n flag to mach run commands. #20122

Uh oh!

Conversation

o0Ignition0o commented Feb 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add windows support to the -n flag.

Uh oh!

highfive commented Feb 26, 2018

Uh oh!

highfive commented Feb 26, 2018

Uh oh!

tigercosmos commented Feb 26, 2018

Uh oh!

o0Ignition0o commented Feb 26, 2018

Uh oh!

jdm left a comment

Choose a reason for hiding this comment

Uh oh!

jdm Mar 5, 2018

Choose a reason for hiding this comment

Uh oh!

jdm Mar 5, 2018

Choose a reason for hiding this comment

Uh oh!

o0Ignition0o Mar 8, 2018

Choose a reason for hiding this comment

Uh oh!

jdm Mar 8, 2018

Choose a reason for hiding this comment

Uh oh!

o0Ignition0o Mar 9, 2018

Choose a reason for hiding this comment

Uh oh!

bors-servo commented Mar 7, 2018

Uh oh!

o0Ignition0o commented Mar 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdm commented Mar 11, 2018

Uh oh!

o0Ignition0o commented Mar 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdm commented Mar 16, 2018

Uh oh!

bors-servo commented Mar 16, 2018

Uh oh!

bors-servo commented Mar 16, 2018

Uh oh!

bors-servo commented Mar 16, 2018

Uh oh!

Uh oh!

o0Ignition0o commented Feb 26, 2018 •

edited

Loading

o0Ignition0o commented Mar 11, 2018 •

edited

Loading

o0Ignition0o commented Mar 11, 2018 •

edited

Loading