Assign a name to iframes when loading the initial about:blank #21976

notriddle · 2018-10-17T20:55:35Z

Before, it would assign the name too late, causing scripts (which will not wait for another tick) to accidentally spawn pop-up windows instead of loading into the iframe.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Slither.io very broken #21886
There are tests for these changes

This change is

highfive · 2018-10-17T20:55:39Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/htmliframeelement.rs
@KiChjang: components/script/dom/htmliframeelement.rs

servo-wpt-sync · 2018-10-17T20:56:19Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#13585.

notriddle · 2018-10-17T21:01:58Z

Warning: the test case in this PR doesn't pass yet

This PR allows slither.io to be opened and played.

However, due to a second bug in the iframe implementation, the load event handler which performs the assertion is being called too early. It should be called only when the form is finished, but is instead being called by the initial about:blank document.

servo-wpt-sync · 2018-10-17T21:04:43Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#13585.

servo-wpt-sync · 2018-10-17T21:07:34Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#13585.

Before, it would assign the name too late, causing scripts (which will not wait for another tick) to accidentally spawn pop-up windows instead of loading into the iframe.

servo-wpt-sync · 2018-10-19T00:22:10Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#13585.

notriddle · 2018-10-19T00:24:25Z

WIP marker removed -- ready to review

Turns out I was misunderstanding a few things, and the Servo behavior is within the documented behavior of the spec (it's Firefox that's being weird, by synchronously firing events). The mute load event flag wouldn't be set even if it was implemented, because the about:blank load event task would be run before the form plan-navigate task would.

So, fixed the test to ignore the blank document.

At documentElement.appendChild(frame), the task queue will contain [ iframe_load_event ]
Then, at form.submit(), the task queue will contain [ iframe_load_event, form_plan_navigate ]
Then, when the end of the script is reached, it will first run iframe_load_event: notice that the mute load event flag is not set. The task queue now contains [ form_plan_navigate ], and my callback already got called once.
Then, it pops off the next task, finally running form_plan_navigate, which now sets the mute load event flag (after it has already been fired), and eventually leads to my callback being called a second time.

notriddle · 2018-10-19T00:29:21Z

@bors-servo try=wpt

bors-servo · 2018-10-19T00:29:28Z

⌛ Trying commit eafcd91 with merge 5dbf83a...

Assign a name to iframes when loading the initial about:blank Before, it would assign the name too late, causing scripts (which will not wait for another tick) to accidentally spawn pop-up windows instead of loading into the iframe. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21886 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21976)

bors-servo · 2018-10-19T00:53:39Z

💔 Test failed - linux-rel-wpt

notriddle · 2018-10-19T01:35:10Z

{"status": "TIMEOUT", "group": "default", "message": "Test timed out", "stack": null, "subtest": "Targeting nested browsing contexts", "test": "/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.html", "line": 170625, "action": "test_result", "expected": "FAIL"}
{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.html", "line": 170626, "action": "test_result", "expected": "OK"}

It was already broken, since Servo doesn't support pop-up windows. The iframe changes just made it broken in a different way.

servo-wpt-sync · 2018-10-23T00:56:24Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#13585.

notriddle · 2018-10-23T17:37:31Z

@bors-servo try=wpt

bors-servo · 2018-10-23T17:37:40Z

⌛ Trying commit 7270333 with merge ff8cadf...

Assign a name to iframes when loading the initial about:blank Before, it would assign the name too late, causing scripts (which will not wait for another tick) to accidentally spawn pop-up windows instead of loading into the iframe. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21886 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21976)

bors-servo · 2018-10-23T18:03:33Z

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

jdm

Thanks for looking into this so carefully!

jdm · 2018-10-29T12:18:38Z

...s/wpt/web-platform-tests/html/semantics/forms/form-submission-target/form-target-iframe.html

+<script src="/resources/testharnessreport.js"></script>
+<script>
+async_test(function(t) {
+  window.addEventListener("load", function() {


This should pass t.step_func(function() { instead.

jdm · 2018-10-29T12:19:05Z

...s/wpt/web-platform-tests/html/semantics/forms/form-submission-target/form-target-iframe.html

+    form.appendChild(input);
+    document.documentElement.appendChild(form);
+    form.submit();
+    frame.addEventListener("load", function() {


This should also pass t.step_func(function() {

jdm · 2018-10-29T12:20:44Z

...s/wpt/web-platform-tests/html/semantics/forms/form-submission-target/form-target-iframe.html

+    document.documentElement.appendChild(form);
+    form.submit();
+    frame.addEventListener("load", function() {
+      if (frame.contentWindow.location.href != "about:blank") {


Could we make this check for the actual expected value instead? Maybe using new URL("form-target-iframe-helper.py", window.location)?

servo-wpt-sync · 2018-10-29T18:55:47Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#13585.

jdm · 2018-10-29T19:17:43Z

@bors-servo r+

bors-servo · 2018-10-29T19:17:44Z

📌 Commit 10442ae has been approved by jdm

bors-servo · 2018-10-29T19:29:35Z

⌛ Testing commit 10442ae with merge 2f8dc65...

Assign a name to iframes when loading the initial about:blank Before, it would assign the name too late, causing scripts (which will not wait for another tick) to accidentally spawn pop-up windows instead of loading into the iframe. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21886 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21976)

bors-servo · 2018-10-29T19:57:36Z

💔 Test failed - linux-rel-wpt

notriddle · 2018-10-29T20:12:54Z

@bors-servo retry

Out-of-memory

bors-servo · 2018-10-29T20:12:58Z

⚡ Previous build results for android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css2, mac-rel-wpt3, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4...

bors-servo · 2018-10-29T20:45:09Z

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing 2f8dc65 to master...

highfive assigned SimonSapin Oct 17, 2018

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 17, 2018

servo-wpt-sync mentioned this pull request Oct 17, 2018

Assign a name to iframes when loading the initial about:blank web-platform-tests/wpt#13585

Merged

notriddle added the S-work-in-progress label Oct 17, 2018

Assign a name to iframes when loading the initial about:blank

eafcd91

Before, it would assign the name too late, causing scripts (which will not wait for another tick) to accidentally spawn pop-up windows instead of loading into the iframe.

notriddle removed the S-work-in-progress label Oct 19, 2018

highfive added the S-tests-failed The changes caused existing tests to fail. label Oct 19, 2018

Skip pop-up centric WPT test

7270333

It was already broken, since Servo doesn't support pop-up windows. The iframe changes just made it broken in a different way.

highfive removed the S-tests-failed The changes caused existing tests to fail. label Oct 23, 2018

jdm requested changes Oct 29, 2018

View reviewed changes

jdm assigned jdm and unassigned SimonSapin Oct 29, 2018

jdm added the S-needs-code-changes Changes have not yet been made that were requested by a reviewer. label Oct 29, 2018

jdm removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 29, 2018

Use t.step_func and expected path checking

10442ae

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Oct 29, 2018

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 29, 2018

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 29, 2018

bors-servo merged commit 10442ae into servo:master Oct 29, 2018

notriddle deleted the iframe-target-form-race branch October 29, 2018 20:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assign a name to iframes when loading the initial about:blank #21976

Assign a name to iframes when loading the initial about:blank #21976

notriddle commented Oct 17, 2018 •

edited by SimonSapin

Loading

highfive commented Oct 17, 2018

servo-wpt-sync commented Oct 17, 2018

notriddle commented Oct 17, 2018

servo-wpt-sync commented Oct 17, 2018

servo-wpt-sync commented Oct 17, 2018

servo-wpt-sync commented Oct 19, 2018

notriddle commented Oct 19, 2018 •

edited

Loading

notriddle commented Oct 19, 2018

bors-servo commented Oct 19, 2018

bors-servo commented Oct 19, 2018

notriddle commented Oct 19, 2018

servo-wpt-sync commented Oct 23, 2018

notriddle commented Oct 23, 2018

bors-servo commented Oct 23, 2018

bors-servo commented Oct 23, 2018

jdm left a comment

jdm Oct 29, 2018

jdm Oct 29, 2018

jdm Oct 29, 2018

servo-wpt-sync commented Oct 29, 2018

jdm commented Oct 29, 2018

bors-servo commented Oct 29, 2018

bors-servo commented Oct 29, 2018

bors-servo commented Oct 29, 2018

notriddle commented Oct 29, 2018

bors-servo commented Oct 29, 2018

bors-servo commented Oct 29, 2018

Assign a name to iframes when loading the initial about:blank #21976

Assign a name to iframes when loading the initial about:blank #21976

Conversation

notriddle commented Oct 17, 2018 • edited by SimonSapin Loading

highfive commented Oct 17, 2018

servo-wpt-sync commented Oct 17, 2018

notriddle commented Oct 17, 2018

Warning: the test case in this PR doesn't pass yet

servo-wpt-sync commented Oct 17, 2018

servo-wpt-sync commented Oct 17, 2018

servo-wpt-sync commented Oct 19, 2018

notriddle commented Oct 19, 2018 • edited Loading

WIP marker removed -- ready to review

notriddle commented Oct 19, 2018

bors-servo commented Oct 19, 2018

bors-servo commented Oct 19, 2018

notriddle commented Oct 19, 2018

servo-wpt-sync commented Oct 23, 2018

notriddle commented Oct 23, 2018

bors-servo commented Oct 23, 2018

bors-servo commented Oct 23, 2018

jdm left a comment

Choose a reason for hiding this comment

jdm Oct 29, 2018

Choose a reason for hiding this comment

jdm Oct 29, 2018

Choose a reason for hiding this comment

jdm Oct 29, 2018

Choose a reason for hiding this comment

servo-wpt-sync commented Oct 29, 2018

jdm commented Oct 29, 2018

bors-servo commented Oct 29, 2018

bors-servo commented Oct 29, 2018

bors-servo commented Oct 29, 2018

notriddle commented Oct 29, 2018

bors-servo commented Oct 29, 2018

bors-servo commented Oct 29, 2018

notriddle commented Oct 17, 2018 •

edited by SimonSapin

Loading

notriddle commented Oct 19, 2018 •

edited

Loading