Join GitHub today
Assign a name to iframes when loading the initial about:blank #21976
Before, it would assign the name too late, causing scripts (which will not wait for another tick) to accidentally spawn pop-up windows instead of loading into the iframe.
referenced this pull request
Oct 17, 2018
Warning: the test case in this PR doesn't pass yet
This PR allows slither.io to be opened and played.
However, due to a second bug in the iframe implementation, the
1 similar comment
WIP marker removed -- ready to review
Turns out I was misunderstanding a few things, and the Servo behavior is within the documented behavior of the spec (it's Firefox that's being weird, by synchronously firing events). The
So, fixed the test to ignore the blank document.
added a commit
this pull request
Oct 19, 2018