Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glutin 0.21 #23457

Merged
merged 5 commits into from May 25, 2019

Conversation

Projects
None yet
5 participants
@jdm
Copy link
Member

commented May 25, 2019

This is just #23288 taking into account the lessons learned in #23448 so that Android builds successfully.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 25, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml
  • @KiChjang: components/script/Cargo.toml
  • @edunham: servo-tidy.toml
  • @paulrouget: ports/glutin/embedder.rs, ports/glutin/Cargo.toml, ports/glutin/main2.rs, ports/glutin/headed_window.rs, ports/glutin/context.rs
  • @emilio: components/style/Cargo.toml, components/layout/Cargo.toml
@highfive

This comment has been minimized.

Copy link

commented May 25, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@jdm jdm force-pushed the jdm:glutes branch from 12b389d to 2875e5c May 25, 2019

@jdm

This comment has been minimized.

Copy link
Member Author

commented May 25, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

📌 Commit 2875e5c has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

⌛️ Testing commit 2875e5c with merge a97eb93...

bors-servo added a commit that referenced this pull request May 25, 2019

Auto merge of #23457 - jdm:glutes, r=jdm
Glutin 0.21

This is just #23288 taking into account the lessons learned in #23448 so that Android builds successfully.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23457)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing a97eb93 to master...

@bors-servo bors-servo merged commit 2875e5c into servo:master May 25, 2019

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@paulrouget

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Do we understand why parking_lot 0.7 was posing problems?

@jdm

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

Nope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.