Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glutin 0.21 #23457

Merged
merged 5 commits into from May 25, 2019
Merged

Glutin 0.21 #23457

merged 5 commits into from May 25, 2019

Conversation

@jdm
Copy link
Member

@jdm jdm commented May 25, 2019

This is just #23288 taking into account the lessons learned in #23448 so that Android builds successfully.


This change is Reviewable

@highfive
Copy link

@highfive highfive commented May 25, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml
  • @KiChjang: components/script/Cargo.toml
  • @edunham: servo-tidy.toml
  • @paulrouget: ports/glutin/embedder.rs, ports/glutin/Cargo.toml, ports/glutin/main2.rs, ports/glutin/headed_window.rs, ports/glutin/context.rs
  • @emilio: components/style/Cargo.toml, components/layout/Cargo.toml

@highfive
Copy link

@highfive highfive commented May 25, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@jdm
Copy link
Member Author

@jdm jdm commented May 25, 2019

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 25, 2019

📌 Commit 2875e5c has been approved by jdm

@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 25, 2019

Testing commit 2875e5c with merge a97eb93...

bors-servo added a commit that referenced this issue May 25, 2019
Glutin 0.21

This is just #23288 taking into account the lessons learned in #23448 so that Android builds successfully.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23457)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo commented May 25, 2019

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing a97eb93 to master...

@bors-servo bors-servo merged commit 2875e5c into servo:master May 25, 2019
3 of 4 checks passed
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented May 27, 2019

Do we understand why parking_lot 0.7 was posing problems?

@jdm
Copy link
Member Author

@jdm jdm commented May 27, 2019

Nope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants