Skip to content

Glutin 0.21 #23457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 25, 2019
Merged

Glutin 0.21 #23457

merged 5 commits into from
May 25, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented May 25, 2019 •
edited by SimonSapin
Loading

This is just #23288 taking into account the lessons learned in #23448 so that Android builds successfully.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml
  • @KiChjang: components/script/Cargo.toml
  • @edunham: servo-tidy.toml
  • @paulrouget: ports/glutin/embedder.rs, ports/glutin/Cargo.toml, ports/glutin/main2.rs, ports/glutin/headed_window.rs, ports/glutin/context.rs
  • @emilio: components/style/Cargo.toml, components/layout/Cargo.toml

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 25, 2019
@jdm
Copy link
Member Author

jdm commented May 25, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 2875e5c has been approved by jdm

@highfive highfive assigned jdm and unassigned avadacatavra May 25, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 25, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 2875e5c with merge a97eb93...

bors-servo pushed a commit that referenced this pull request May 25, 2019
Auto merge of #23457 - jdm:glutes, r=jdm
a97eb93 
Glutin 0.21

This is just #23288 taking into account the lessons learned in #23448 so that Android builds successfully.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23457)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - arm64, linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing a97eb93 to master...

@bors-servo bors-servo merged commit 2875e5c into servo:master May 25, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 25, 2019
@paulrouget
Copy link
Contributor

Do we understand why parking_lot 0.7 was posing problems?

@paulrouget paulrouget mentioned this pull request May 27, 2019
Closed
@jdm
Copy link
Member Author

jdm commented May 27, 2019

Nope.

This was referenced May 31, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdm @highfive @bors-servo @paulrouget @avadacatavra