Fix: #4260. Click event is now a MouseEvent #4718
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
|
Critic review: https://critic.hoppipolla.co.uk/r/3828 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
jdm
added
S-awaiting-review
|
Thanks for the change, and I'm sorry it took so long for us to review it! I've left stylistic nit in the Critic review, and then this will need to be rebased on top of a recent master revision. |
jdm
added
S-needs-code-changes
|
@liamzdenek Are you planning to continue working on this? |
|
@jdm Sorry, I don't have the time. |
|
That's fine; thanks for your help! |
jdm
added
the
S-needs-new-owner
|
I'll pick up this. |
tetsuharuohzeki
added a commit
to tetsuharuohzeki/servo
that referenced
this pull request
Feb 24, 2015
This original commit is servo#4718.
tetsuharuohzeki
pushed a commit
to tetsuharuohzeki/servo
that referenced
this pull request
Feb 28, 2015
This original commit is servo#4718.
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this pull request
Jun 12, 2017
…vent); r=jdm Fix #4260 Pick up: This original commit is servo/servo#4718. Source-Repo: https://github.com/servo/servo Source-Revision: b261d27ac5fc5e8a858b344087792f9b1709ee55
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…vent); r=jdm Fix #4260 Pick up: This original commit is servo/servo#4718. Source-Repo: https://github.com/servo/servo Source-Revision: b261d27ac5fc5e8a858b344087792f9b1709ee55 UltraBlame original commit: 87fb1f22fd7db60712409347404d07ef5ec0faf0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…vent); r=jdm Fix #4260 Pick up: This original commit is servo/servo#4718. Source-Repo: https://github.com/servo/servo Source-Revision: b261d27ac5fc5e8a858b344087792f9b1709ee55 UltraBlame original commit: 87fb1f22fd7db60712409347404d07ef5ec0faf0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…vent); r=jdm Fix #4260 Pick up: This original commit is servo/servo#4718. Source-Repo: https://github.com/servo/servo Source-Revision: b261d27ac5fc5e8a858b344087792f9b1709ee55 UltraBlame original commit: 87fb1f22fd7db60712409347404d07ef5ec0faf0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.