Fix inflate size for inset box shadow. #2261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This causes a CI failure in the wrench reftests - I haven't looked to check if it looks like a bug or just a slight reference image update is required. |
|
The wrench test is about box shadow and the max difference is one. I think I should update the image as well. |
demo99
force-pushed
the
box_shadow_inset3
branch
from
2cf4bdd to
7106877
Compare
|
Thanks! @bors-servo r+ |
|
📌 Commit 7106877 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 8, 2018
Fix inflate size for inset box shadow. The inflate size should be multiplied by 2 when downscaling to guarantee the 1 pixel extra edge. This should fix issue #2182 and [bug 1423696](https://bugzilla.mozilla.org/show_bug.cgi?id=1423696). gecko try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aac72b3488afd74fce9afcd4edf7ce17763bd57e&selectedJob=154326187 There is an unexpected-pass test. I will add a patch to bug 1423696. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2261) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inflate size should be multiplied by 2 when downscaling to guarantee the 1 pixel extra edge. This should fix issue #2182 and bug 1423696.
gecko try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aac72b3488afd74fce9afcd4edf7ce17763bd57e&selectedJob=154326187
There is an unexpected-pass test. I will add a patch to bug 1423696.
This change is